-
-
Notifications
You must be signed in to change notification settings - Fork 287
Automate Docker image building, update configuration process #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
julowe
wants to merge
24
commits into
vrtmrz:main
Choose a base branch
from
julowe:docker-automation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile just copies in the local.ini file The local.ini file is mostly a conversion of the utils/couchdb/couchdb-init.sh script.
This reverts commit 2ed51f9.
http://localhost:5984/_node/_local/_config shows a `# username` user...
fix yaml to the 2 space indent fix markdown formatting
… if not a pull request this should now make the pull request checks run succesfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
So this is still very much a draft pull request right now - I wanted to ask questions about repo/file organization, formatting, and documentation. The code should be in a (mostly?) finished state. And there aren't many substantive changes, just a shuffling of pieces really so that the method is the same, just the exact process changed.
Pull Request Contents
This pull request would enable github to automatically create and publish to its container registry a docker image whenever the (few) relevant files are changed.
I created a
local.inifile from the curl commands in the bash script.The Dockerfile just pulls the couchdb image and copies in the
local.inifile.I created a docker-compose file that uses docker persistent named volumes instead of mapping local directories or files.
I wrote up the start of some documentation of commands etc, but I kept it separate for now (mostly so I could focus on documenting what I was doing and writing it, instead of trying to fit it into existing documentation right away). So I wanted to ask and see how it could best be integrated to current 'setup your own server' documentation. That existing documentation file is a bit confusing to me. I have not yet made many actual edits to it, but there are some formatting changes I've checked in so far to this branch.
I've pushed it to the main branch of my fork to make sure the action work, so you can actually see the image now and install it with my instructions. https://github.com/julowe/obsidian-livesync/pkgs/container/obsidian-livesync
I have tested the compose and run methods and both seem to work well. I've cribbed some from https://github.com/oleduc/docker-obsidian-livesync-couchdb so I'll @oleduc as well to see if they have any input.
I think these changes will allow for an easier as well as automated way for people to get this docker container running. That was actually a major reason I started this work, so I could more easily use the container with a docker home-lab manager I use - Ref: my compose file for Cosmos Cloud
Questions
local.inifiles in the other readme files. Are they the most up to date configurations, or better to go off of the shell script? I did not yet check to see what is the current format and sectioning of specific configuration items in the ini file. I also wasn't sure which config lines should be kept in place, or doubled up in different sections if you wanted to retain backwards compatibility? (I believe I saw that in an issue, but lost track of which one)dockersubdirectory as to not clutter up the actual pluginI know I had more to ask, but forget, so I'll post this draft for now.