General fixes to dependencies, tests and code to be able to run tests#479
Open
cvarela-usesi wants to merge 1 commit intovtex-apps:mainfrom
Open
General fixes to dependencies, tests and code to be able to run tests#479cvarela-usesi wants to merge 1 commit intovtex-apps:mainfrom
cvarela-usesi wants to merge 1 commit intovtex-apps:mainfrom
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
When working with an app forked from this main repo, I was unable to run tests from root directory, and when ran from node directory, there were several failed tests.
I also was unable to run lint from there.
With the changes made, now both lint and tests can be run with yarn
How should this be manually tested?
This can be manually tested this way from root (please make sure you have this version for yarn: v1.22.10):
yarn test
Workspace
Checklist/Reminders
README.md.CHANGELOG.md.Screenshots or example usage
Tests passing:

Lint running and detecting warnings and errors:

Type of changes
Notes