Create new optional request option for customizing local cache behavior #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mairatma
commented
Nov 8, 2023
Comment on lines
+5
to
+7
| get (key: K, fetcher?: () => Promise<FetchResult<V>>, options?: LocalCacheOptions): Promise<V | void> | V | void, | ||
| has (key: K, options?: LocalCacheOptions): Promise<boolean> | boolean, | ||
| set (key: K, value: V, maxAge?: number | void, options?: LocalCacheOptions): Promise<boolean> | boolean, |
There was a problem hiding this comment.
This allows all cache classes to receive this new optional param.
mairatma
force-pushed
the
feat/cacheOptions
branch
2 times, most recently
from
8c42d10 to
d9594b4
Compare
mairatma
requested review from
filafb,
danzanzini,
filipewl and
arturpimentel
mairatma
force-pushed
the
feat/cacheOptions
branch
from
d9594b4 to
c49223e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Created a new config that can be passed per request, to customize local caching behavior.
What problem is this solving?
We need more complex behaviors for our local caches, and this will allow customizing the logic per request.
How should this be manually tested?
Types of changes