-
Notifications
You must be signed in to change notification settings - Fork 15
Bump axios from 0.21.1 to 1.8.2 #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
28
commits into
master
Choose a base branch
from
dependabot/npm_and_yarn/axios-1.8.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
This way we can properly build the lib into this project
This had to do with the different error handling typing introduced in TS 4.0.0 and also with typings for Axios' `AxiosRequestConfig.responseEncoding`, which now also can be a string.
I had to rework a default for a header object from null to {} since it wouldn't be accepted as a AxiosRequestConfig in the new typings from the lib
Axios reworked its typings for headers, which made them incompatible with IOResponse's definition for headers. I used a old workaround to get through this: (T as any)
I had to cast many things here to any in order to avoid risking to change the API we provide to outside the library
In this case, I just clause-guarded the error handling for an instance of AxiosError since the doing the operations that happen after it wouldn't make sense otherwise.
Here, I also clause-guarded the error handling for an AxiosError instance
Once again, I use any-casting to maintain compatibility between AxiosRequestConfig and IORequestConfig
Cast to any to avoid problems between AxiosRequestConfig and IORequestConfig
Once again, only make error handling if we're actually dealing with an AxiosError
Only handle errors if they are actually instances of Error. Otherwise the operations thereafters wouldn't make any sense
Only handle errors if they are instances of Error. Otherwise, it wouldn't make sense to pass them along to ErrorReport.create()
Only handle instances of Error
Only handle errors which are instances of ApolloError. This particular error handler expects errors will come as extensions of ApolloError, otherwise the operations within the error handler wouldn't make any sense.
Only make operations with status codes if the error is an AxiosError
InternalAxiosRequestConfig is now the actual type being used in AxiosResponse. So our TraceableAxiosRequestConfig should implement that instead of what it was implementing before.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update javascript code
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps axios from 0.21.1 to 1.8.2.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
... (truncated)
Commits
a9f7689
chore(release): v1.8.2 (#6812)fb8eec2
fix(http-adapter): add allowAbsoluteUrls to path building (#6810)9812045
chore(sponsor): update sponsor block (#6804)72acf75
chore(sponsor): update sponsor block (#6794)2e64afd
chore(release): v1.8.1 (#6800)36a5a62
fix(utils): movegenerateString
to platform utils to avoid importing crypto...cceb7b1
chore(release): v1.8.0 (#6795)23a25af
fix(utils): replace getRandomValues with crypto module (#6788)32c7bcc
feat: Add config for ignoring absolute URLs (#5902) (#6192)4a3e26c
chore(config): adjust rollup config to preserve license header to minified Ja...Maintainer changes
This version was pushed to npm by jasonsaayman, a new releaser for axios since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.