Add concurrency extension for Swift 5.5.2 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Daohan, and thanks a lot for the pull request! It’s an interesting addition, but I think we should add a bit more documentation/comment around it. Maybe add a sample code in the README? |
vtourraine
reviewed
Jan 25, 2022
| } | ||
| } | ||
|
|
||
| open class func openCompose(_ client: ThirdPartyMailClient = .systemDefault, recipient: String? = nil, subject: String? = nil, body: String? = nil, cc: String? = nil, bcc: String? = nil) async -> Bool { |
There was a problem hiding this comment.
Couldn’t we define just one method, with a default value for the application parameter?
There was a problem hiding this comment.
Good question!
I tried @MainActor here but still could not add this default parameter:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar change: https://github.com/ReactiveX/RxSwift/pull/2367/files
This can help us improve the completion callback.