ci: avoid CI failures for forks #2497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 34 34
Lines 3003 3003
Branches 846 846
=======================================
Hits 2850 2850
Misses 150 150
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the CI jobs only work for
vuejs/routerand fail when pushing changes to forks.This PR restricts those jobs so that they don't run on forks.
The approach is based on:
One of the jobs already has a check on
github.event.pull_request.head.repo.fork, but that only helps for pull requests. Pushing commits to themainbranch of a fork will still run the job, failing due to the missing secrets.In theory, somebody might want to run these workflows on their fork, but I think that only makes sense if they don't intend to merge them back into the main repo, in which case they can just edit the workflow configs on their fork.