Skip to content

feat: migrate tailwind color palette #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

feat: migrate tailwind color palette #3282

merged 4 commits into from
Aug 13, 2025

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Jul 10, 2025

upgrade vueuse

Related issue

Closes #

Scope of work

https://www.figma.com/design/CWOkbpne0tDpSenT4ZEUTQ/SFUI-2-%7C-Design-Kit-v2.7--redesign-?m=auto&node-id=19478-53189

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@FRSgit FRSgit self-assigned this Jul 10, 2025
Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: 48cd955

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@storefront-ui/vue Major
@storefront-ui/tailwind-config Major
@storefront-ui/nuxt Patch
@storefront-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FRSgit FRSgit marked this pull request as ready for review July 28, 2025 21:52
@FRSgit FRSgit force-pushed the feat/redesign branch 3 times, most recently from ee178d1 to 676f224 Compare July 29, 2025 09:06
@@ -3,7 +3,7 @@ import { ShowcasePageLayout } from '../../showcases';
export default function TypographyDefault() {
return (
<div className="prose">
<figcaption>The New Winner</figcaption>
<em>The New Winner</em>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess its about warning ? if so <3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. It was an obvious error, so I took care of it 😄

@@ -0,0 +1,76 @@
--white: #FFFFFFFF;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this file with hex colors or is it leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it so it's easier to figure out in the future which values has changed (in figma colors are in hex). Also it should be easier to change and translate values to oklch once again if needed

@@ -0,0 +1,266 @@
// usage: node ./scripts/rgbToOklch.js > output-colors.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this script needed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I'd prefer to leave it for the future 😄

@FRSgit FRSgit merged commit 31aa18f into v2-develop Aug 13, 2025
14 checks passed
@FRSgit FRSgit deleted the feat/redesign branch August 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants