-
Notifications
You must be signed in to change notification settings - Fork 460
feat: migrate tailwind color palette #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 48cd955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ee178d1
to
676f224
Compare
upgrade vueuse
pin cypress/code-coverage pkg version
@@ -3,7 +3,7 @@ import { ShowcasePageLayout } from '../../showcases'; | |||
export default function TypographyDefault() { | |||
return ( | |||
<div className="prose"> | |||
<figcaption>The New Winner</figcaption> | |||
<em>The New Winner</em> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess its about warning ? if so <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. It was an obvious error, so I took care of it 😄
@@ -0,0 +1,76 @@ | |||
--white: #FFFFFFFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this file with hex colors or is it leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it so it's easier to figure out in the future which values has changed (in figma colors are in hex). Also it should be easier to change and translate values to oklch once again if needed
@@ -0,0 +1,266 @@ | |||
// usage: node ./scripts/rgbToOklch.js > output-colors.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this script needed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I'd prefer to leave it for the future 😄
upgrade vueuse
Related issue
Closes #
Scope of work
https://www.figma.com/design/CWOkbpne0tDpSenT4ZEUTQ/SFUI-2-%7C-Design-Kit-v2.7--redesign-?m=auto&node-id=19478-53189
Screenshots of visual changes
Checklist