-
Notifications
You must be signed in to change notification settings - Fork 460
feat: redesign display block #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/redesign-button
Are you sure you want to change the base?
Conversation
|
upgrade vueuse
pin cypress/code-coverage pkg version
86bd45b
to
b1fbe71
Compare
d8028c0
to
1aa7b7d
Compare
897cb92
to
64ba2e2
Compare
64ba2e2
to
cfeed4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding paddings - I'm not sure if I understood: can you explain it to me in more detail? Display sizing is based on image size (so it's always a rectangle and stays at 50% of the width). Here is the screenshot from figma design: I don't know if that helps though 😄 |
Preview in react fixed: bc7c284 |
@FRSgit When you got on smaller resolution, the padding around texts is kinda big |
30a659d
to
69f6276
Compare
Related issue
Closes #
Scope of work
https://www.figma.com/design/CWOkbpne0tDpSenT4ZEUTQ/SFUI-2-%7C-Design-Kit-v2.7--redesign-?m=auto&node-id=23187-93170
Screenshots of visual changes
Checklist