Skip to content

feat: redesign display block #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: feat/redesign-button
Choose a base branch
from

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Jul 10, 2025

Related issue

Closes #

Scope of work

https://www.figma.com/design/CWOkbpne0tDpSenT4ZEUTQ/SFUI-2-%7C-Design-Kit-v2.7--redesign-?m=auto&node-id=23187-93170

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@FRSgit FRSgit self-assigned this Jul 10, 2025
Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: bc7c284

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@FRSgit FRSgit force-pushed the feat/redesign-button branch from 86bd45b to b1fbe71 Compare July 29, 2025 09:45
@FRSgit FRSgit force-pushed the feat/redesign-display branch from d8028c0 to 1aa7b7d Compare July 29, 2025 09:47
@FRSgit FRSgit force-pushed the feat/redesign-display branch 3 times, most recently from 897cb92 to 64ba2e2 Compare August 1, 2025 07:58
@FRSgit FRSgit force-pushed the feat/redesign-display branch from 64ba2e2 to cfeed4b Compare August 10, 2025 10:53
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have feeling that paddings for smaller resolution in vertical display is too much, wdyt?
image

DisplayWithImageOverlay on react preview does not work
image

@FRSgit
Copy link
Contributor Author

FRSgit commented Aug 11, 2025

Regarding paddings - I'm not sure if I understood: can you explain it to me in more detail?

Display sizing is based on image size (so it's always a rectangle and stays at 50% of the width). Here is the screenshot from figma design:
image

I don't know if that helps though 😄

@FRSgit
Copy link
Contributor Author

FRSgit commented Aug 11, 2025

Preview in react fixed: bc7c284

@Szymon-dziewonski
Copy link
Contributor

@FRSgit When you got on smaller resolution, the padding around texts is kinda big p-6 https://github.com/vuestorefront/storefront-ui/pull/3284/files#diff-3907a78f80ded957742a4a4abd441f4616892a7263edb3b796b637fdee4fbcbcR59 so then text is really small, imho there should be breakpoint and then applying smaller padding like p-4

@FRSgit FRSgit force-pushed the feat/redesign-button branch from 30a659d to 69f6276 Compare August 13, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants