feat: redesign hero block #3288
Conversation
FRSgit
force-pushed
the
feat/redesign-hero
branch
from
658c3c0 to
bf36bb0
Compare
|
FRSgit
force-pushed
the
feat/redesign-display
branch
from
897cb92 to
64ba2e2
Compare
FRSgit
force-pushed
the
feat/redesign-display
branch
from
64ba2e2 to
cfeed4b
Compare
FRSgit
force-pushed
the
feat/redesign-hero
branch
from
bf36bb0 to
68c020f
Compare
| <div className="relative min-h-[576px]"> | ||
| <picture> | ||
| <source srcSet="http://localhost:3100/@assets/hero-bg.png" media="(min-width: 768px)" /> | ||
| <div className="relative h-dvh w-dvh"> |
There was a problem hiding this comment.
in design it should be 864px not device height, is this something decided on behind scenes?
There was a problem hiding this comment.
yea, the 864px is some random value - it's meant to be fullscreen
| <div className="h-full w-full max-w-[1536px] mx-auto p-4 md:px-10 flex flex-col justify-end md:justify-center text-white"> | ||
| <p className="typography-text-xs md:typography-text-sm font-bold tracking-widest uppercase">Feel the music</p> | ||
| <h1 className="typography-display-2 md:typography-display-1 md:leading-[67.5px] font-bold mt-2 mb-4"> | ||
| New Wireless Pro |
There was a problem hiding this comment.
copy is not changed
There was a problem hiding this comment.
good catch, button was wrong as well: 2ba296a
There was a problem hiding this comment.
yep whole section had wrong copy but i figure out you will get that :D
upgrade tailwindcss to 3.4.17
add second hero example
FRSgit
force-pushed
the
feat/redesign-hero
branch
from
68c020f to
3772316
Compare
add second hero example
Related issue
Closes #
Scope of work
Screenshots of visual changes
Checklist