-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Events API #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c1aac0a
feat: Events API
cuebit 01ba24b
test(events): mock self-removing subscribers
cuebit f39ad6b
chore(events): ensure final emit value
cuebit 5220c7b
chore(events): rename parent directory
cuebit 5536c1e
fix(events): object path
cuebit 780c125
Merge branch 'master' into feature/events
cuebit 2579960
chore(events): clean up code
cuebit 4034d4c
feat(events): subscribe to wildcard events
cuebit 4c6ad5d
test(events): validate event forwarding
cuebit fc7f1a0
refactor(events): utility function + typings
cuebit a842d0e
chore: protect `removeAllListeners` from user-land side-effects
cuebit 4e599bf
fix(events): failing `removeAllListeners` test
cuebit e3cf879
chore: format code comments
cuebit 016ec0d
chore: additional comment styling
cuebit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| import { isFunction } from '../support/Utils' | ||
|
|
||
| export type EventArgs<T> = T extends any[] ? T : never | ||
|
|
||
| export type EventListener<T, K extends keyof T> = ( | ||
| ...args: EventArgs<T[K]> | ||
| ) => void | ||
|
|
||
| export type EventSubscriberArgs<T> = { | ||
| [K in keyof T]: { event: K; args: EventArgs<T[K]> } | ||
| }[keyof T] | ||
|
|
||
| export type EventSubscriber<T> = (arg: EventSubscriberArgs<T>) => void | ||
|
|
||
| /** | ||
| * Events class for listening to and emitting of events. | ||
| * | ||
| * @public | ||
| */ | ||
| export class Events<T> { | ||
| /** | ||
| * The registry for listeners. | ||
| */ | ||
| protected listeners: { [K in keyof T]?: EventListener<T, K>[] } | ||
|
|
||
| /** | ||
| * The registry for subscribers. | ||
| */ | ||
| protected subscribers: EventSubscriber<T>[] | ||
|
|
||
| /** | ||
| * Creates an Events instance. | ||
| */ | ||
| constructor() { | ||
| this.listeners = Object.create(null) | ||
| this.subscribers = [] | ||
| } | ||
|
|
||
| /** | ||
| * Register a listener for a given event. | ||
| * | ||
| * @returns A function that, when called, will unregister the handler. | ||
| */ | ||
| on<K extends keyof T>(event: K, callback: EventListener<T, K>): () => void { | ||
| if (!event || !isFunction(callback)) { | ||
| return () => {} // Non-blocking noop. | ||
| } | ||
|
|
||
| ;(this.listeners[event] = this.listeners[event]! || []).push(callback) | ||
|
|
||
| return () => { | ||
| if (callback) { | ||
| this.off(event, callback) | ||
| ;(callback as any) = null // Free up memory. | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Register a one-time listener for a given event. | ||
| * | ||
| * @returns A function that, when called, will self-execute and unregister the handler. | ||
| */ | ||
| once<K extends keyof T>( | ||
| event: K, | ||
| callback: EventListener<T, K> | ||
| ): EventListener<T, K> { | ||
| const fn = (...args: EventArgs<T[K]>) => { | ||
| this.off(event, fn) | ||
|
|
||
| return callback(...args) | ||
| } | ||
|
|
||
| this.on(event, fn) | ||
|
|
||
| return fn | ||
| } | ||
|
|
||
| /** | ||
| * Unregister a listener for a given event. | ||
| */ | ||
| off<K extends keyof T>(event: K, callback: EventListener<T, K>): void { | ||
| const stack = this.listeners[event] | ||
|
|
||
| if (!stack) { | ||
| return | ||
| } | ||
|
|
||
| const i = stack.indexOf(callback) | ||
|
|
||
| i > -1 && stack.splice(i, 1) | ||
|
|
||
| stack.length === 0 && delete this.listeners[event] | ||
| } | ||
|
|
||
| /** | ||
| * Register a handler for wildcard event subscriber. | ||
| * | ||
| * @returns A function that, when called, will unregister the handler. | ||
| */ | ||
| subscribe(callback: EventSubscriber<T>): () => void { | ||
| this.subscribers.push(callback) | ||
|
|
||
| return () => { | ||
| const i = this.subscribers.indexOf(callback) | ||
|
|
||
| i > -1 && this.subscribers.splice(i, 1) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Call all handlers for a given event with the specified args(?). | ||
| */ | ||
| emit<K extends keyof T>(event: K, ...args: EventArgs<T[K]>): void { | ||
| const stack = this.listeners[event] | ||
|
|
||
| if (stack) { | ||
| stack.slice().forEach((listener) => listener(...args)) | ||
| } | ||
|
|
||
| this.subscribers.slice().forEach((sub) => sub({ event, args })) | ||
| } | ||
|
|
||
| /** | ||
| * Remove all listeners for a given event. | ||
| */ | ||
| protected removeAllListeners<K extends keyof T>(event: K): void { | ||
| event && this.listeners[event] && delete this.listeners[event] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| import { Events } from '@/events/Events' | ||
|
|
||
| describe('unit/events/Events', () => { | ||
| interface TEvents { | ||
| test: [boolean] | ||
| trial: [] | ||
| } | ||
|
|
||
| it('can register event listeners', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| events.on('test', spy) | ||
|
|
||
| expect(events['listeners']).toHaveProperty('test') | ||
| expect(events['listeners'].test).toHaveLength(1) | ||
| expect(events['listeners'].test).toEqual([spy]) | ||
| }) | ||
|
|
||
| it('can ignore empty event names', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| ;[0, '', null, undefined].forEach((e) => { | ||
| events.on(e as any, () => {}) | ||
| }) | ||
|
|
||
| expect(events['listeners']).toEqual({}) | ||
| }) | ||
|
|
||
| it('can ignore non-function handlers', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| ;[0, '', null, undefined].forEach((e) => { | ||
| const cb = events.on('test', e as any) | ||
| cb() | ||
| }) | ||
|
|
||
| expect(events['listeners']).toEqual({}) | ||
| }) | ||
|
|
||
| it('can emit events', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| events.on('test', spy) | ||
| events.emit('test', true) | ||
|
|
||
| events.off('test', spy) | ||
| events.emit('test', false) | ||
|
|
||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| expect(spy).toHaveBeenLastCalledWith(true) | ||
| expect(events['listeners']).toEqual({}) | ||
| }) | ||
|
|
||
| it('can noop when removing unknown listeners', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy1 = jest.fn() | ||
| const spy2 = jest.fn() | ||
|
|
||
| expect(events['listeners'].test).toBeUndefined() | ||
|
|
||
| events.off('test', spy1) | ||
|
|
||
| expect(events['listeners'].test).toBeUndefined() | ||
|
|
||
| events.on('test', spy2) | ||
| events.off('test', spy1) | ||
|
|
||
| expect(events['listeners'].test).toEqual([spy2]) | ||
| }) | ||
|
|
||
| it('can unregister itself', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| events.on('test', spy) | ||
| const unsub = events.on('test', spy) | ||
|
|
||
| expect(events['listeners'].test).toHaveLength(2) | ||
|
|
||
| unsub() | ||
| unsub() | ||
|
|
||
| expect(events['listeners'].test).toHaveLength(1) | ||
| expect(events['listeners'].test).toEqual([spy]) | ||
| }) | ||
|
|
||
| it('can register one-time listeners', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy1 = jest.fn() | ||
| const spy2 = jest.fn() | ||
|
|
||
| events.once('test', spy1) | ||
| events.on('test', spy2) | ||
|
|
||
| expect(events['listeners'].test).toHaveLength(2) | ||
|
|
||
| events.emit('test', true) | ||
| events.emit('test', false) | ||
|
|
||
| expect(events['listeners'].test).toHaveLength(1) | ||
| expect(spy1).toHaveBeenCalledTimes(1) | ||
| expect(spy1).toHaveBeenCalledWith(true) | ||
| expect(spy2).toHaveBeenCalledTimes(2) | ||
| expect(spy2).toHaveBeenLastCalledWith(false) | ||
| }) | ||
|
|
||
| it('can emit events to subscribers', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| const unsub = events.subscribe(spy) | ||
|
|
||
| events.emit('test', true) | ||
| unsub() | ||
| events.emit('trial') | ||
|
|
||
| expect(events['subscribers']).toEqual([]) | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| expect(spy).toHaveBeenCalledWith({ event: 'test', args: [true] }) | ||
| }) | ||
|
|
||
| it('can forward events within subscribers', () => { | ||
| const events1 = new Events<TEvents>() | ||
| const events2 = new Events<Pick<TEvents, 'test'>>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| events2.subscribe(({ event, args }) => { | ||
| events1.emit(event, ...args) | ||
| }) | ||
|
|
||
| events1.on('test', spy) | ||
| events2.emit('test', true) | ||
|
|
||
| expect(spy).toHaveBeenLastCalledWith(true) | ||
| }) | ||
|
|
||
| it('can remove all event listeners', () => { | ||
| const events = new Events<TEvents>() | ||
|
|
||
| const spy = jest.fn() | ||
|
|
||
| events.on('test', spy) | ||
| events.on('trial', spy) | ||
| events.on('test', spy) | ||
|
|
||
| expect(events['listeners'].test).toHaveLength(2) | ||
|
|
||
| events['removeAllListeners']('test') | ||
|
|
||
| expect(events['listeners'].test).toBeUndefined() | ||
| expect(events['listeners'].trial).toHaveLength(1) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.