Skip to content

Conversation

@jestabro
Copy link
Contributor

@jestabro jestabro commented May 27, 2025

Change Summary

This requires merge of PRs:
vyos/vyconf#23
vyos-legacy/libvyosconfig#40
vyos/vyos-1x#4526

Conditionally call vy_* replacements for certain my_* commands, notably my_set and my_commit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyconf#23
vyos-legacy/libvyosconfig#40
vyos/vyos-1x#4526

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025

👍
No issues in PR Title / Commit Title

Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change for when vyconf backend is active

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything falls back to the old backend unless VyConf is explicitly enabled, I see no reason not to merge this into current. We should give people a way to test the new backend without having to install it by hand.

@dmbaturin dmbaturin merged commit 532fc2d into vyos:current Jun 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants