T7374: teardown vyconf config session on CLI config session exit #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
10 tasks
dmbaturin
approved these changes
May 19, 2025
There was a problem hiding this comment.
Certainly necessary for vyconf-based sessions. My only comment is if we should change the name of the configuration-capable user group to vyoscfg already, in the light of reintroduction of operator users. But we can always do it later, it's not a prerequisite for this PR.
c-po
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is an initial piece for the integration with vyconf-aware Python modules and the CLI. Only applicable after PR:
vyos/vyos-1x#4505
Types of changes
Related Task(s)
Related PR(s)
vyos/vyconf#21
vyos/libvyosconfig#36
vyos/vyos-1x#4505
vyos/vyos-build#963
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: