Skip to content

vyos.configtree: T4318: Allow set tag flag to true or false #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Oct 7, 2024

Change Summary

set_tag(path: list, flag: bool=True) — now can set node's tag flag to false.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/libvyosconfig#20

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Oct 7, 2024

👍
No issues in PR Title / Commit Title

@natali-rs1985 natali-rs1985 marked this pull request as draft October 7, 2024 10:57
@jestabro jestabro changed the title vyos.configtree: T4918: Allow set tag flag to true or false vyos.configtree: T4318: Allow set tag flag to true or false Oct 7, 2024
@jestabro jestabro self-requested a review October 7, 2024 18:12
Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should reference T4318, not T4918

@jestabro jestabro self-requested a review October 7, 2024 18:51
Copy link

github-actions bot commented Oct 7, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@jestabro jestabro marked this pull request as ready for review October 7, 2024 20:32
@jestabro jestabro merged commit 7d42643 into vyos:current Oct 7, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants