-
Notifications
You must be signed in to change notification settings - Fork 383
Sflow: T7175: Added VPP option #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.
❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase please and add commit messgae in this format Sflow: T7175: Added VPP option
(use commit --amend and force push)
All contributors have signed the CLA ✍️ ✅ |
CI integration 👍 passed! Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash please PR to one commit
@@ -112,6 +112,12 @@ | |||
<valueless/> | |||
</properties> | |||
</leafNode> | |||
<leafNode name="enable-vpp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about just vpp
?
set system sflow vpp
I cant seem to get this to squash properly, il just redo it later when i get some time. |
Change summary
Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.
Types of changes
Related Task(s)
https://vyos.dev/T7175
Related PR(s)
vyos/vyos-build#962
vyos/vyos-vpp#32
How to test / Smoketest result
Checklist: