http-api: T3955: add commit-confirm to endpoints /configure /config-file

[jestabro]

Change summary

Requests to the endpoints /configure and /config-file may include a field confirm_time of type int, which if > 0 will invoke commit-confirm with timeout := confirm_time on success of the request operation (set|delete|load|merge).

Confirming the operation is performed with a request containing 'op': 'confirm' to the respective endpoint.

An example for a list of set operations to endpoint /configure; other cases are analogous:

└──> curl -k -X POST -d '{"key": "baz", "commands": [{"op": "set", "path": ["interfaces", "ethernet", "eth1", "address", "192.168.2.137/24"]},{"op": "set", "path": ["interfaces", "ethernet", "eth1", "description", "test"]}], "confirm_time": 1}' https://192.168.122.230/configure
{"success": true, "data": "Initialized commit-confirm; 1 minutes to confirm before reload\n", "error": null}% 

└──> curl -k -X POST -d '{"key": "baz", "op": "confirm"}' https://192.168.122.230/configure
{"success": true, "data": "Reload timer stopped\n", "error": null}% 

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
  T3955: add commit-confirm example vyos-documentation#1642

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed

[sever-sever]

It works as expected in my tests.

curl -k -X POST -d '{"key": "baz", "commands": [{"op": "set", "path": ["interfaces", "ethernet", "eth1", "address", "192.168.2.137/24"]},{"op": "set", "path": ["interfaces", "ethernet", "eth1", "description", "test"]}], "confirm_time": 1}' https://192.168.122.14/configure

curl -k -X POST -d '{"key": "baz", "op": "confirm"}' https://192.168.122.14/configure

Logs:

Jun 04 14:31:56 r14 systemd[1]: Started /usr/bin/sg vyattacfg /usr/bin/config-mgmt revert_soft.
Jun 04 14:31:56 r14 vyos-configd[787]: Received message: {"type": "init"}
Jun 04 14:31:56 r14 vyos-configd[787]: config session pid is 5739
Jun 04 14:31:56 r14 vyos-configd[787]: config session sudo_user is root
Jun 04 14:31:56 r14 vyos-configd[787]: commit_scripts: ['interfaces_ethernet_eth1']
Jun 04 14:31:56 r14 vyos-configd[787]: Received message: {"type": "node", "last": true, "data": "VYOS_TAGNODE_VALUE=eth1/usr/libexec/vyos/conf_mode/interfaces_ethernet.py"}
Jun 04 14:31:56 r14 vyos-configd[787]: Sending reply: SUCCESS with output
Jun 04 14:31:56 r14 vyos-configd[787]: scripts_called: ['interfaces_ethernet_eth1']
Jun 04 14:31:57 r14 systemd[1]: opt-vyatta-config-tmp-new_config_5739.mount: Deactivated successfully.
Jun 04 14:31:57 r14 commit[7141]: Successful change to active configuration by user root on unknown
Jun 04 14:31:57 r14 vyos-http-api[5739]: Configuration modified via HTTP API using key 'KID'
Jun 04 14:31:57 r14 vyos-http-api[5739]: INFO:      - "POST /configure HTTP/1.0" 200 OK



Jun 04 14:32:11 r14 systemd[1]: commit-confirm.timer: Deactivated successfully.
Jun 04 14:32:11 r14 systemd[1]: Stopped /usr/bin/sg vyattacfg /usr/bin/config-mgmt revert_soft.
Jun 04 14:32:12 r14 systemd[1]: opt-vyatta-config-tmp-new_config_5739.mount: Deactivated successfully.
Jun 04 14:32:12 r14 vyos-http-api[5739]: Configuration modified via HTTP API using key 'KID'
Jun 04 14:32:12 r14 vyos-http-api[5739]: INFO:      - "POST /configure HTTP/1.0" 200 OK
Jun 04 14:37:37 r14 systemd[1]: Starting Cleanup of Temporary Directories...
Jun 04 14:37:37 r14 systemd[1]: systemd-tmpfiles-clean.service: Deactivated successfully.
Jun 04 14:37:37 r14 systemd[1]: Finished Cleanup of Temporary Directories.
Jun 04 14:37:37 r14 systemd[1]: run-credentials-systemd\x2dtmpfiles\x2dclean.service.mount: Deactivated successfully.
^C
vyos@r14:~$ 

checked confirm and rollback without confirmation