Skip to content

op-mode: T7509: add "detail" and "wide" modifier for BGP advertised-routes|received-routes #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

op-mode: T7509: add "detail" and "wide" modifier for BGP advertised-routes|received-routes #4538

merged 3 commits into from
Jun 3, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 1, 2025

Change summary

Add new op-mode commands to support both the detailed and wide modifier for BGP neighbors advertised- and received-routes.

show ip bgp neighbors <ip> received-routes [detail [wide]|wide]
show bgp neighbors <ip> received-routes [detail [wide]|wide]
show bgp ipv4 neighbors <ip> received-routes [detail [wide]|wide]
show bgp ipv6 neighbors <ip> received-routes [detail [wide]|wide]
show bgp vrf <name> neighbors <ip> received-routes [detail [wide]|wide]
show bgp vrf <name> ipv4 neighbors <ip> received-routes [detail [wide]|wide]
show bgp vrf <name> ipv6 neighbors <ip> received-routes [detail [wide]|wide]

show ip bgp neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp ipv4 neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp ipv6 neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp vrf <name> neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp vrf <name> ipv4 neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp vrf <name> ipv6 neighbors <ip> advertised-routes [detail [wide]|wide]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits June 1, 2025 13:26
@c-po
op-mode: T7509: add "detail" and "wide" modifier for advertised-routes
d7df1ae 
show ip bgp neighbors <ip> advertised-routes [detail [wide]|wide]

show bgp neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp ipv4 neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp ipv6 neighbors <ip> advertised-routes [detail [wide]|wide]

show bgp vrf <name> neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp vrf <name> ipv4 neighbors <ip> advertised-routes [detail [wide]|wide]
show bgp vrf <name> ipv6 neighbors <ip> advertised-routes [detail [wide]|wide]
@c-po
op-mode: T7509: add "detail" and "wide" modifier for received-routes
e5183e6 
show ip bgp neighbors <ip> received-routes [detail [wide]|wide]

show bgp neighbors <ip> received-routes [detail [wide]|wide]
show bgp ipv4 neighbors <ip> received-routes [detail [wide]|wide]
show bgp ipv6 neighbors <ip> received-routes [detail [wide]|wide]

show bgp vrf <name> neighbors <ip> received-routes [detail [wide]|wide]
show bgp vrf <name> ipv4 neighbors <ip> received-routes [detail [wide]|wide]
show bgp vrf <name> ipv6 neighbors <ip> received-routes [detail [wide]|wide]
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Jun 1, 2025
@c-po c-po requested review from sarthurdev and sever-sever June 1, 2025 12:00
sever-sever
sever-sever approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend op-mode commands for BGP neighbors
Implementation looks correct.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

dmbaturin
dmbaturin approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a safe change since it just exposed more commands, no objections.

@dmbaturin dmbaturin merged commit a711ceb into vyos:current Jun 3, 2025
15 of 16 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Jun 3, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jun 3, 2025
@c-po c-po deleted the op-mode-bgp branch June 8, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev

Assignees

@c-po c-po

Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-po @dmbaturin @sever-sever @vyosbot