T7626: op-mode: fix several op-mode command for syntax

[tjjh89017]

Change summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T7626

Related PR(s)

How to test / Smoketest result

update container image XXX

And without error like

-vbash: syntax error near unexpected token `then'

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

❌
PR title does not match the required format

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

1 out of 2 committers have signed the CLA.
✅ (tjjh89017)[https://github.com/tjjh89017]
❌ @dmbaturin
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[tjjh89017]

I have read the CLA Document and I hereby sign the CLA

[sever-sever]

We used shell scripts for other commands 1d32420

[dmbaturin]

Something certainly needs to be done about those commands. I'm not exactly against merging this PR, but the deal is that it already says "fix update container" but in reality fixes three unrelated commands, and there are more commands with embedded shell scripts still left, mainly in show log.

@tjjh89017 Do you want to take up fixing the rest? It's ok if not, then I can rename this PR to something generic and approve it.

[tjjh89017]

Hi @dmbaturin
i think first thing is deciding the style for the command here for the future.
If this style is acceptable currently, I think it's still hard to find all command to fix them at once.
You can rename this PR to something generic.
Thank you

[dmbaturin]

@tjjh89017 I think it's an acceptable stop-gap measure and it's good that we can identify all commands like that by grepping for sh -c.

I think the long-term plan should be to provide a function in the standardized op mode API for this, and a corresponding tag in the op mode schema — or perhaps make it implicit in the script if that function exists. I need to think about it and put those thoughts in a Phorge task, but we still need to fix the immediate issue, since converting all those commands to standardized op mode will take quite a bit longer.

[tjjh89017]

@dmbaturin
Ok, I think we could consider to change the name for this PR at this moment.
and find some way to grep all of incorrect existing command to a list for new PR.
Especially, some commands require shell trick to escape the variables.

[sever-sever]

@tjjh89017 could you rebase the PR?

[tjjh89017]

@tjjh89017 could you rebase the PR?

I rebased it.
Please help me to check (I'll wait for CI.)
Thank you

[Copilot]

Pull Request Overview

This PR fixes syntax errors in op-mode commands by properly wrapping shell conditionals in bash -c blocks. The changes address shell syntax issues that were causing errors like "syntax error near unexpected token 'then'" when executing these commands.

• Wraps if-then-else statements in bash -c blocks to ensure proper shell execution
• Adds proper quoting for variables and string literals within the bash commands
• Fixes three op-mode commands: show log certbot, show environment sensors, and update container image

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
op-mode-definitions/show-log.xml.in	Wraps certbot log command in bash -c for proper if-then-else execution
op-mode-definitions/show-environment.xml.in	Wraps sensors command in bash -c and fixes path variable quoting
op-mode-definitions/container.xml.in	Wraps container update command in bash -c and adds proper variable quoting

[dmbaturin]

Let's merge it as is and then we can fix the remaining commands ourselves. Thanks, @tjjh89017 !

[tjjh89017]

thank you

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed