-
Notifications
You must be signed in to change notification settings - Fork 383
T5797: Adjust MSS clamping from forward to postrouting hook #4609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All contributors have signed the CLA ✍️ ✅ |
👍 |
I have read the CLA Document and I hereby sign the CLA |
If possible, could this be backported to sagitta and/or circinus? I've tested this on 1.4.2 and it's working okay on a MPLS PE router currently. |
fb8f9c9
to
2fe7fa0
Compare
CI integration 👍 passed! Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the TCP-MSS option for forwarded and local generated traffic from the router itself.
I do not see any bad things with this implementation.
We'll probably separate this in the future if we face any harm.
Like:
set interfaces ethernet ethX tcp-mss hook <forward | postrouting>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See no issues, tested locally and works same as previously.
Change summary
Adjust the VYOS_TCP_MSS chain to hook on postrouting instead of forward in order to fix MSS clamping not being adequately applied when MPLS/VRF is used.
Types of changes
Related Task(s)
https://vyos.dev/T5797
Related PR(s)
How to test / Smoketest result
You should see
You should no longer see
Checklist: