Skip to content

pylint: T7648: disable some linter-checks hit by GitHub action pipeline #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 24, 2025

Change summary

Fix an issue (by disabling the pylint line) when builds are run in the GitHub CI pipeline.

Running pylint --errors-only ...
************* Module interfaces
src/op_mode/interfaces.py:42:54: E1101: Instance of '_IO' has no 'fileno' member (no-member)
************* Module show_techsupport_report
src/op_mode/show_techsupport_report.py:62:50: E1101: Instance of '_IO' has no 'fileno' member (no-member)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jul 24, 2025

👍
No issues in PR Title / Commit Title

Running pylint --errors-only ...
************* Module interfaces
src/op_mode/interfaces.py:42:54: E1101: Instance of '_IO' has no 'fileno' member (no-member)
************* Module show_techsupport_report
src/op_mode/show_techsupport_report.py:62:50: E1101: Instance of '_IO' has no 'fileno' member (no-member)
@c-po c-po requested review from jestabro and sever-sever July 24, 2025 14:25
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linter check

@c-po c-po merged commit fca865d into current Jul 24, 2025
15 of 16 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 24, 2025
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants