Skip to content

T7292: add build dependency python3-protobuf #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

jestabro
Copy link
Contributor

Used at build of python modules to autogenerate dataclasses from vyconf.proto.

Change summary

NOTE that this requires the following to avoid build errors, as described in https://vyos.dev/T7296:
vyos/vyos-1x#4426
It will remain in draft until the above is merged.

Add build dependency needed for autogeneration of dataclasses from the vyconf.proto file:
vyos/vyos-1x#4427

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Used at build of python modules to autogenerate dataclasses from
vyconf.proto.
@jestabro jestabro self-assigned this Mar 31, 2025
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Mar 31, 2025
@jestabro jestabro marked this pull request as ready for review March 31, 2025 15:33
Copy link
Member

@sarthurdev sarthurdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense why this package is needed based on the vyos-1x PR.

@jestabro jestabro merged commit dd2c245 into vyos:current Apr 1, 2025
8 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants