Skip to content

build: T7301: do not include the GPG image signing key in images #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

Minisign signing has been in place for a long time, so there's no need for the legacy GPG signing anymore.

Removing gnupg/gpgv from package lists doesn't have negative effects because they are installed as dependencies of APT in any case.

Companion PR: vyos/vyos-1x#4429

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): obsolete functionality removal

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Apr 1, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 1, 2025
@dmbaturin dmbaturin added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Apr 1, 2025
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing legacy GPG signing was discussed in the maintainers' meeting.
Do not have any objection.

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove legacy validation key

@c-po c-po merged commit 1b00253 into vyos:current Apr 1, 2025
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants