Skip to content

packages: T7344: build bash-completion from source #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

packages: T7344: build bash-completion from source #941

merged 1 commit into from
Apr 10, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

Building it is much safer than using a Buster repo that may unintentionally serve as a source of older packages and regressions in the image (that already happened with tzdata once) and Buster repos will not be easily usable forever.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): new package build scripts.

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 10, 2025
@dmbaturin dmbaturin added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus and removed current VyOS rolling release labels Apr 10, 2025
This was referenced Apr 10, 2025
Merged
Merged
@dmbaturin dmbaturin force-pushed the T7344-build-bash-completion branch from 0ba00e8 to 58c60ae Compare April 10, 2025 14:11
@github-actions github-actions bot added the current VyOS rolling release label Apr 10, 2025
sever-sever
sever-sever approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works and build binaries

@sever-sever sever-sever requested a review from evgsentrium April 10, 2025 15:52
@dmbaturin dmbaturin force-pushed the T7344-build-bash-completion branch from 58c60ae to 1a9b4cd Compare April 10, 2025 16:55
@sever-sever sever-sever merged commit 2f18905 into vyos:current Apr 10, 2025
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@evgsentrium evgsentrium Awaiting requested review from evgsentrium

Assignees

@dmbaturin dmbaturin

Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @sever-sever @vyosbot