Skip to content

packages: T6230: include iptables modules in vyos-ipt-netflow #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

Without those libs, the kernel module can be loaded, but iptables targets to send packets to the module for accounting are not available.

Testing

Both these commands should work:

modprobe ipt_NETFLOW destination=127.0.0.1:2055

iptables -I FORWARD -j NETFLOW

Package contents after the change:

vyos_bld@fa920bd24f5a:/vyos/scripts/package-build/linux-kernel$ dpkg-deb -c ./vyos-ipt-netflow_2.6-17-g0eb2092_amd64.deb 
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./usr/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./usr/share/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./usr/share/doc/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./usr/share/doc/vyos-ipt-netflow/
-rw-r--r-- 0/0             162 2025-04-17 15:50 ./usr/share/doc/vyos-ipt-netflow/changelog.gz
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/x86_64-linux-gnu/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/x86_64-linux-gnu/xtables/
-rwxr-xr-x 0/0           15936 2025-04-17 15:50 ./lib/x86_64-linux-gnu/xtables/libip6t_NETFLOW.so
-rwxr-xr-x 0/0           15936 2025-04-17 15:50 ./lib/x86_64-linux-gnu/xtables/libipt_NETFLOW.so
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/modules/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/modules/6.6.79-vyos/
drwxr-xr-x 0/0               0 2025-04-17 15:50 ./lib/modules/6.6.79-vyos/extra/
-rw-r--r-- 0/0          152775 2025-04-17 15:50 ./lib/modules/6.6.79-vyos/extra/ipt_NETFLOW.ko
vyos_bld@fa920bd24f5a:/vyos/scripts/package-build/linux-kernel$ 

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 17, 2025
@c-po c-po requested review from c-po, sarthurdev and sever-sever April 17, 2025 20:11
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing shared libraries to the resulting package.

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add required libs to binary.

@sever-sever sever-sever merged commit 351e596 into vyos:current Apr 18, 2025
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants