Skip to content

build: T7372: correctly quote lb_config arguments #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

build: T7372: correctly quote lb_config arguments #948

merged 1 commit into from
Apr 20, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

This PR fixes the root cause of all the trouble with archive areas that @Embezzle had to go through in #922 and, hopefully, all similar problems that may occur in the future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 18, 2025
sever-sever
sever-sever approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it is more safer to use quotes

c-po
c-po approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place variable in quotes to properly bind them to a config option.

@c-po c-po added the bp/circinus Create automatic backport for circinus label Apr 20, 2025
@c-po c-po merged commit d401c8f into vyos:current Apr 20, 2025
7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@c-po c-po c-po approved these changes

Assignees

@dmbaturin dmbaturin

Labels
bp/circinus Create automatic backport for circinus current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmbaturin @sever-sever @c-po @vyosbot