Skip to content

T7367: syslog.service links to rsyslog.service - thus disable it, too #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

T7367: syslog.service links to rsyslog.service - thus disable it, too #951

merged 1 commit into from
Apr 23, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 20, 2025

Change summary

The default syslog implementation should make syslog.service a symlink to itself, so that this socket activates the right actual syslog service. As rsyslog service is already disabled - also take care of the linked service.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
T7367: syslog.service links to rsyslog.service - thus disable it, too
6f9bcdb 
The default syslog implementation should make syslog.service a symlink to
itself, so that this socket activates the right actual syslog service. As
rsyslog service is already disabled - also take care of the linked service.
@c-po c-po mentioned this pull request Apr 20, 2025
Merged
12 tasks
@c-po c-po added the bp/circinus Create automatic backport for circinus label Apr 20, 2025
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 20, 2025
@c-po c-po requested review from zdc, jestabro and sever-sever April 20, 2025 19:29
dmbaturin
dmbaturin approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, no objections.

@c-po c-po merged commit 818e89f into vyos:current Apr 23, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Apr 23, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 23, 2025
@c-po c-po deleted the syslog-T7367 branch April 24, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@zdc zdc Awaiting requested review from zdc

@jestabro jestabro Awaiting requested review from jestabro

@sever-sever sever-sever Awaiting requested review from sever-sever

Assignees

@c-po c-po

Labels
bp/circinus Create automatic backport for circinus current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @vyosbot