Skip to content

build: T7399: remove the APT option to allow downgrades #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

There was a concern about TACACS+ libs, but the change doesn't affect them — correct versions are installed.

vyos@vyos:~$ dpkg -l | grep tacplus
ii  libnss-tacplus                   1.0.4-cl5.1.0u11.1               amd64        NSS module for TACACS+ authentication without local passwd entry
ii  libpam-tacplus                   1.4.3-cl5.1.0u5                  amd64        PAM module for using TACACS+ as an authentication service
ii  libtacplus-map1                  1.0.1-cl5.1.0u9                  amd64        Library for mapping TACACS+ users without local /etc/passwd entries

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Apr 25, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 25, 2025
It doesn't appear necessary anymore, if it ever was
@dmbaturin dmbaturin force-pushed the T7399-no-apt-downgrade branch from 49e0528 to 1f400a4 Compare April 25, 2025 18:45
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed at the meeting.
I do not see any harm in removing this option

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local build and tests run fine

@c-po c-po merged commit 58a30bd into vyos:current Apr 28, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Apr 28, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants