Skip to content

build: T7409: do not include MD5 checksums in the ISO image #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

It simply removes MD5 sums from the internal image integrity check and leaves only SHA-256.

I verified that it has no effect on upgrade (even from 1.3.8) or on live CD boot.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Apr 28, 2025
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable. Older supported images ship md5 as interim step to enable sha256 verification in upcoming images.

Local build passes, too

@jestabro jestabro self-requested a review April 29, 2025 14:22
@dmbaturin dmbaturin added the bp/circinus Create automatic backport for circinus label Apr 29, 2025
@dmbaturin dmbaturin merged commit 65f3b10 into vyos:current Apr 29, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Apr 29, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants