Skip to content

Kernel: T7428: remove io_uring support #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

c-po
Copy link
Member

@c-po c-po commented May 4, 2025

Change summary

Given the recent chatter about io_uring and it flaws - e.g. here - and we have to my knowledge no use for it we should remove it from the Kernel configuration.

Every feature not used and removed from the Kernel is a good one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits May 4, 2025 23:43
Given the recent chatter about io_uring and it flaws - e.g. [1] - and we have
to my knowledge no use for it we should remove it from the Kernel configuration.

Every feature not used and removed from the Kernel is a good one.

1: https://www.armosec.io/blog/io_uring-rootkit-bypasses-linux-security/
@c-po c-po requested a review from sever-sever May 4, 2025 21:47
Copy link

github-actions bot commented May 4, 2025

👍
No issues in PR Title / Commit Title

@c-po c-po requested a review from zdc May 4, 2025 21:47
@github-actions github-actions bot added the current VyOS rolling release label May 4, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If smoke tests still pass with this change, I have nothing against it. It's never late to re-enable kernel features if we find a good use for them and they improve.

@dmbaturin dmbaturin merged commit 0b98048 into vyos:current May 5, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label May 5, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels May 5, 2025
@c-po c-po deleted the io_uring branch May 17, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants