Skip to content

Kernel: T7253: build linux-perf-$version package #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2025
Merged

Kernel: T7253: build linux-perf-$version package #961

merged 5 commits into from
May 15, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented May 12, 2025

Change summary

Previous patch was removed during VyOS 1.3 -> 1.4 development cycle as the internal handling for Kernel package generation changed.

This brings back the perf binary in a new linux-perf-$KERNELVERSION Debian package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from zdc May 12, 2025 16:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

❌
PR title does not match the required format

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels May 12, 2025
@github-actions github-actions bot added the current VyOS rolling release label May 12, 2025
c-po added 2 commits May 12, 2025 20:45
@c-po
Docker: T7253: remove Kernel build dependencies to shrink container i…
73df823 
…mage

Move the Kernel build dependencies to package.toml to unbload the build
container even more.
@c-po
Kernel: T7253: build linux-perf-$version package
1545aa4 
Previous patch was removed during VyOS 1.3 -> 1.4 development cycle as the
internal handling for Kernel package generation changed.

This brings back the perf binary in a new linux-perf-$KERNELVERSION
Debian package.
@c-po c-po force-pushed the kernel-perf-T7253 branch from 56d5d86 to 1545aa4 Compare May 12, 2025 18:46
sever-sever
sever-sever reviewed May 13, 2025
View reviewed changes
docker/Dockerfile
libudev-dev \
ruby-dev \
rubygems \
build-essential
Copy link
Member

@sever-sever sever-sever May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it (build-essential), it is used not only for the packages in the linux-kernel build dir.
Possible affected packages:

  • vyos/vpp
  • vyos/vyatta-cfg
  • vyos/libpam-radius-auth
  • vyos/libnss-mapuser
  • vyos/vyatta-bash

and so on... where C is used.

@c-po
Docker: T7253: re-add build-essential dependency for vyos-1x
ffcf9b4 
vyshim consists out of C code which needs the build-essential
package.
dmbaturin
dmbaturin approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea to keep most dependencies out of the base container image. build-essential certainly should be in the base image, the rest I

sever-sever
sever-sever approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move dependency from container to the build package
Return linux-perf package

@sever-sever sever-sever merged commit fcbd8d6 into vyos:current May 15, 2025
1 of 6 checks passed
@c-po c-po deleted the kernel-perf-T7253 branch May 17, 2025 13:12
@kumvijaya kumvijaya added the mirror-initiated This PR initiated for mirror sync workflow label May 17, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sever-sever sever-sever sever-sever approved these changes

@zdc zdc Awaiting requested review from zdc

Assignees

@c-po c-po

Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c-po @dmbaturin @sever-sever @kumvijaya @vyosbot