Skip to content

docker: T7450: use PCRE2 for vyos-utils and libvyosconfig #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

dmbaturin
Copy link
Member

@dmbaturin dmbaturin commented May 13, 2025

Change summary

vyos-utils and vyos1x-config now use the original pcre OCaml package. That package is based on the original PCRE library. Its latest release 8.45 is the last release and the original implementation is now declared EOL. That package is named libpcre3 in Debian, for some reason.

PCRE maintainers made a new release line called PCRE2 that has now replaced the original. Debian Trixie no longer includes the original implementation, only PCRE2. The package is called libpcre2. Yes, you read it right: libpcre2 is newer than libpcre3.

There are already OCaml bindings for PCRE2 — they are API-compatible, just use a different module name, so we only need to update those names and dependencies to make it work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): dependency update.

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label May 13, 2025
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to "newer" PCRE2 package even if the version number is smaller. Needed for ongoing effort updating to Debian Trixie.

Change looks reasonable.

@jestabro jestabro self-requested a review May 13, 2025 13:10
Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update package as required for Trixie.

@dmbaturin dmbaturin merged commit 1cf889b into vyos:current May 13, 2025
7 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label May 13, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants