Define rule set evaluation

[afs]

Work to define rule set evaluation.

• See this document rendered online here

[afs]

Very early work to show direction.

[osavkovic]

Very early work to show direction.

Hi Andy, could you say a bit more about what kind of input you expect here? For instance, should I provide comments and edits, and should I make them in the document or here?

Thanks, O.

[TallTed]

Suggested change

	An expression is evaluated with respect to a [=solution mapping=] to give
	an [=RDF term=] result.
	An expression is evaluated with respect to a [=solution mapping=] to
	result in an [=RDF term=].

[TallTed]

Suggested change

	If two solutions are comptible, the merge of two solutions is the solution that maps variables of
	each solution to the [=RDF term=] from one or other of the solutions.
	If two solutions are compatible, the merge of two solutions is the solution that maps
	variables of each solution to the [=RDF term=] from one or other of the solutions.

[afs]

Done - though should be rewritten to use mapping composition. S1 ∘ S2

[afs]

Very early work to show direction.

Hi Andy, could you say a bit more about what kind of input you expect here? For instance, should I provide comments and edits, and should I make them in the document or here?

Thanks, O.

This is a (currently draft - i.e. unfinished) PR.

You can make comments and suggest changes here.

All changes come in via pull requests; we do not edit the document directly.

PRs are checked for IPR acceptability automatically. Merging PRs has a policy; in this repo, the policy is to have at least one approval. That is, at a minimum, for governance; someone else checked the submitter has followed process and isn't doing anythign silly. But usually an approval is a general agreement on the content and implied direction.

Changes are not fixed - a later PR can revise designs. This is common.

The default branch of this repo, unusually called gh-pages, not main, should be branch-protected, meaning no one can push directly to it.

[liviorobaldo]

Dear Andy and all,

I tried to update the document. Apologies in advance if I made any mistakes or misunderstood something. It’s my first time working on a W3C working group repo. However, from what I understood from Andy, my update won’t go through until some of you approve it, so feel free to delete anything if I got it wrong 🙂

I thought we should clarify in “2. Outline” that rules can also create new RDF resources and new literals. I included an example of the former (an example of the latter is already in “3. Speculative features”, where a new literal is created and bound to ?FN using concat). I also pointed out that this may lead to infinite loops if a user keeps re-applying the rules. However, as I understand it, we agreed in this issue that avoiding such loops is beyond the scope of SHACL rules; it is up to the programmer to iterate rules only under conditions that prevent infinite loops.

By the way, in “3. Speculative features”, I think we should discuss negation-as-failure and aggregates. The former is already there. However, I’m not clear on what the title “Speculative features” is meant to convey. From what I recall, we decided that we want negation-as-failure and aggregates, so they shouldn’t really be described as speculative.

Cheers
Livio

[afs]

@liviorobaldo

This PR is titled "Define rule set evaluation".
That is its focus and the sections of the document it changes.
The PR was "draft".

You have broken the work I have in-progress and made it hard to deal with @TallTed's suggestions.

Please make a separate PR.

[liviorobaldo]

Dear Andy and all,

My apologies, I didn’t do this on purpose. As I mentioned in my previous message, I’m still learning how to use these tools and understand the collaboration policies for working with all of you.

I now understand that this PR is meant to focus only on Section "6. Shape Rules Evaluation" of the document, so we should restrict comments and edits to that section.

Later today, I will open a new PR titled "SHACL 1.2 Rules - Introduction & Outline", dedicated solely to the first three sections of the document. I will also make sure to explicitly note the scope and invite all of you to review it.

Could you kindly confirm that this is the correct approach? Is there anything else I should pay attention to when I'll create the PR? If I'll make some mistake I will of course delete the new PR.

Thanks again for your patience — I’m still learning and will do my best to avoid causing any inconvenience.

Livio

[afs]

Please remove your commit from this PR.

[liviorobaldo]

Dear Andy,

Ok, apologies again. I am trying to fix my mistake while learning how to use this platform and, of course, to avoid making further errors. I’ve installed GitHub Desktop and opened this branch. I located my commit and can see that “Revert changes in commit” is one of the available options:

Is this the option I should click on?

Thanks for your patience
Livio

[afs]

I don't use GitHub Desktop. It's not available for my OS.

I would have thought you want "reset to commit" where the commit is the place you want to keep. "Define ..."

I hope changes will be made locally so you can check them before pushing them to github.

[liviorobaldo]

Hi Andy,

"Reset to commit" is not selectable, as you can see in the screenshot above. Let me try “Revert changes in commit”. If it does not work or create other troubles, I will remove the content I've added by hand.

As soon as I've time, I will then open a new PR titled "SHACL 1.2 Rules - Introduction & Outline" as I indicated above.

Livio

[liviorobaldo]

PS. I think I managed, can't see anymore the text I've added before in the document rendered online here.

[afs]

"Reset to commit" is not selectable,

Says you can use right-click on the commit you wish to go back to.
https://docs.github.com/en/desktop/managing-commits/resetting-to-a-commit-in-github-desktop

Your screenshot shows the HEAD as focus, not the "Define ..." commit.

“Revert changes in commit” applies your commit but in reverse. See all the lines starting -; the result is 2 commits.

I have reset the branch with a git push -f. A dangerous way to do it (I took a local copy for safety first.) Also - reset the draft flag and cleared the approved flag.

The HEAD is [77aed92] [email protected] (3 days ago) - Define rule set evaluation

[liviorobaldo]

Andy, thank you very much for fixing the troubles I caused. Is there anything I am supposed to do? I think no, because I can now only see one commit, so I think the situation has been restored.