[Editorial] Fix exporting of three algorithms#1061
Merged
stephenmcgruer merged 1 commit intogh-pagesfrom Mar 21, 2026
Merged
Conversation
stephenmcgruer
requested review from
ianbjacobs,
marcoscaceres and
rsolomakhin
as code owners
Open
6 tasks
marcoscaceres
approved these changes
Mar 20, 2026
Member
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
Nit: are you sure you want the “ algorithm” at the end of each export? It might make them more awkward to use. But if you think it’s OK, go for it.
ianbjacobs
approved these changes
Mar 20, 2026
Collaborator
Author
I personally like it, but I tend to prefer spec text that reads a little more like code, which I know is not everyone's cup of tea. So I'll keep it for now, and we can change in future if we find a reason to (I doubt we will). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff