Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AGWG-specific Resolutions paragraph out of common include #1152

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Mar 19, 2025

When reviewing #1119, @remibetin flagged that the blurb that appeared near the top of Resolutions pages was seemingly applied too broadly, as it referenced an AGWG-specific Decisions page but showed up even on APA- and ARIA-related minutes pages.

I followed up with @iadawn today as to whether this should appear on only specifically the AGWG minutes page or AGWG + all TFs under it, and he answered the former.

This PR moves the paragraph out of the common Resolutions include, into specifically the AGWG Resolutions page.

Note that the path of least resistance involves moving the paragraph up above the Minutes / Topics / Resolutions links; if we really want to maintain the order, I may need to juggle some includes.

Preview

I will reach out to Daniel and Roy as to whether there are equivalent pages that would make sense to link from ARIA and APA minutes, respectively.

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for wai-website ready!

Name Link
🔨 Latest commit 7ec0040
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/67db03012498800008ae3004
😎 Deploy Preview https://deploy-preview-1152--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfranqueiro kfranqueiro requested review from iadawn and remibetin March 19, 2025 17:55
@remibetin
Copy link
Member

Thanks @kfranqueiro!

@remibetin remibetin merged commit 13b2ae3 into main Mar 19, 2025
4 checks passed
@remibetin remibetin deleted the kgf-minutes-resolutions-note-agwg branch March 19, 2025 18:05
@remibetin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants