Fix secondary requirements and conformance requirements ids #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for act-rules-format ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kengdoj
reviewed
Mar 13, 2025
kengdoj
reviewed
Mar 13, 2025
kengdoj
reviewed
Mar 13, 2025
kengdoj
reviewed
Mar 13, 2025
Co-authored-by: Kathy Eng <[email protected]>
daniel-montalvo
commented
Mar 13, 2025
|
|
||
| A secondary accessibility requirement is a requirement that is correlated with the rule, but for which the rule is not designed to test. The outcome of the rule impacts the result of the accessibility requirement, but the rule is not intended to test the conformance of that requirement. This correlation often results in some of the rule's test cases not satisfying the secondary accessibility requirement. | ||
| A <dfn data-lt="secondary requirement">secondary accessibility requirement</dfn> is a requirement that is correlated with the rule, but for which the rule is not designed to test. The outcome of the rule impacts the result of the accessibility requirement, but the rule is not intended to test the conformance of that requirement. This correlation often results in some of the rule's test cases not satisfying the secondary accessibility requirement. |
There was a problem hiding this comment.
HI @kengdoj
Thanks for your review. I addressed your suggestions. For these definitions to work properly, I just added this data-lt here so that we can still use [=secondary requirements=] but keep "secondary accessibility requirements` as the visible definition term.
Let me know if you'd prefer something else.
daniel-montalvo
dismissed
kengdoj’s stale review
Thanks much! Changes addressed.
|
@kengdoj Have you had a chance to review my latest changes to this? |
github-actions bot
added a commit
that referenced
this pull request
Apr 22, 2025
SHA: 815ff23 Reason: push, by daniel-montalvo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.