Skip to content

Example numbering is confusing Fixes #563 #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

Example numbering is confusing Fixes #563 #591

merged 3 commits into from
Mar 28, 2025

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Mar 19, 2025 •
edited
Loading

This PR:

  • fixes some classes that missed quotes around them
  • removes manual numbering of examples that clashed with Bikeshed automatic processing
  • Removes the word "Example" from each of the headers, as it is automatically provided by Bikeshed
  • added markup for examples in appendix 1: Expressing ACT Rule results with JSON-LD and EARL {#appendix-data-example}

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for act-rules-format ready!

Name Link
🔨 Latest commit 3d522ca
🔍 Latest deploy log https://app.netlify.com/sites/act-rules-format/deploys/67dacda00eaae7000833935a
😎 Deploy Preview https://deploy-preview-591--act-rules-format.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-montalvo daniel-montalvo linked an issue Mar 19, 2025 that may be closed by this pull request
Example numbering is confusing #563
Closed
@daniel-montalvo
Copy link
Contributor Author

daniel-montalvo commented Mar 28, 2025 •
edited
Loading

@WilcoFiers @kengdoj Have you had a chance to review this?

@daniel-montalvo daniel-montalvo merged commit 945f243 into main Mar 28, 2025
6 checks passed
@daniel-montalvo daniel-montalvo deleted the daniel-montalvo/issue563 branch March 28, 2025 14:40
github-actions bot added a commit that referenced this pull request Mar 28, 2025
@daniel-montalvo @github-actions
Example numbering is confusing Fixes #563 (#591)
72ac3b6 
SHA: 945f243
Reason: push, by daniel-montalvo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@kengdoj kengdoj Awaiting requested review from kengdoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example numbering is confusing
2 participants
@daniel-montalvo @WilcoFiers