Skip to content

Add section on backward compatibility #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2025
Merged

Add section on backward compatibility #597

merged 9 commits into from
Jun 19, 2025

Conversation

WilcoFiers
Copy link
Collaborator

@WilcoFiers WilcoFiers commented Jun 4, 2025

Closes #534

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for act-rules-format ready!

Name Link
🔨 Latest commit 58b12f4
🔍 Latest deploy log https://app.netlify.com/projects/act-rules-format/deploys/68527f620add9a0008bd9663
😎 Deploy Preview https://deploy-preview-597--act-rules-format.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator Author

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add section heading 2.1, add link from 4.11

Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor editorials plus the addition to the changelog list

@@ -629,7 +633,7 @@ This section was previously named "Change Log". Either section name is acceptabl
ACT Rules Format Version {#act-rules-format-version}
-------------------------------------------

An ACT Rule is written for a specific version of the ACT Rules Format. Each ACT Rule <em class="rfc2119">must</em> indicate the version of the ACT Rules Format for which it is written.
An ACT Rule is written for a specific version of the ACT Rules Format. Each ACT Rule <em class="rfc2119">must</em> indicate the version of the ACT Rules Format for which it is written. This is important because the ACT Rules Format is not fully [backward compatible](#backward-compatible).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's correct?

@daniel-montalvo
Copy link
Contributor

@WilcoFiers I am assuming you are talking about the use of "backwards" or "backward". I've removed "backwards" where I suggested it, after conversation with @tamsinewing555 . This should be now ready to go. Is this ready for review now?

@WilcoFiers WilcoFiers merged commit 150a312 into main Jun 19, 2025
6 checks passed
@WilcoFiers WilcoFiers deleted the back-compat branch June 19, 2025 11:12
github-actions bot added a commit that referenced this pull request Jun 19, 2025
SHA: 150a312
Reason: push, by WilcoFiers

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACT 1.1 Backward Compatibility with ACT 1.0
2 participants