Draft
Conversation
foolip
force-pushed
the
bikeshed
branch
7 times, most recently
from
d345143 to
79788b2
Compare
Done using this "elegant" replacement:
```js
source.replace(/(<h[1-6])>(.*?)(<\/h[1-6]>)/g, (_, p1, p2, p3) =>
`${p1} id=${p2.replace(/<dfn.*?>/, '').replace('</dfn>', '').toLowerCase().replace(/\s+/g, '-')}>${p2}${p3}`)
```
> sed -i '' 's/data-lt=/lt=/g' index.bs This leaves a data-lt-noDefault attributes, untouched for now.
This is necessary because ReSpec and Bikeshed don't have the same behavior. ReSpec uses the text content as an alternative by default, while Bikeshed uses only the provided lt, if any is given: https://github.com/w3c/respec/wiki/data-lt https://tabatkins.github.io/bikeshed/#changing-lt
To minimize differences in the transition
ReSpec and Bikeshed requires different escaping here...
This mainly silences warnings about unused definitions.
The licenses of both repos are the same.
Member
|
this seems like a not amazing use of time... ReSpec supports the same features as BikeShed. See #1588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1462.