Skip to content

Add url to contributor name #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vkatsikaros
Copy link
Contributor

@vkatsikaros vkatsikaros commented Oct 22, 2024

I noticed I hadn't a url against my name, now adding.


Preview | Diff

@vkatsikaros
Copy link
Contributor Author

I linked my (new) W3C and github accounts together, and clicked on "revalidate" at https://labs.w3.org/repo-manager/pr/id/w3c/webdriver/1846 but it seems the "user affiliation" still can't be determined.

@w3cbot
Copy link

w3cbot commented Oct 22, 2024

tidoust marked as non substantive for IPR from ash-nazg.

@tidoust
Copy link
Member

tidoust commented Oct 22, 2024

I linked my (new) W3C and github accounts together, and clicked on "revalidate" at https://labs.w3.org/repo-manager/pr/id/w3c/webdriver/1846 but it seems the "user affiliation" still can't be determined.

The "revalidate" button bugs from time to time in my experience. In any case, the IPR bot would have continued to complain because you're not a Working Group participant. I marked the pull request as non-substantive.

@@ -11512,7 +11512,7 @@ <h2>Acknowledgements</h2>
<!-- Simon Stewart --> <a href=http://www.rocketpoweredjetpants.com/>Simon Stewart</a>,
<!-- Sri Harsha --> Sri Harsha,
<!-- Titus Fortner --> Titus Fortner,
<!-- Vangelis Katsikaros --> and Vangelis Katsikaros.
<!-- Vangelis Katsikaros --> and <a href=http://www.vkatsikaros.com/>Vangelis Katsikaros</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While quickly discussing this addition we tend more to remove the URLs all together given that it we cannot guarantee that the page is still owned by that person. Instead we could add the GitHub handle.

Suggested change
<!-- Vangelis Katsikaros --> and <a href=http://www.vkatsikaros.com/>Vangelis Katsikaros</a>.
<!-- Vangelis Katsikaros --> and <a href=https://github.com/vkatsikaros>Vangelis Katsikaros</a>.

But we should most likely do this on a different PR for everyone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whimboo makes sense, we expect the spec to be around for a long time (decades even?). Sorry for the noise!

@whimboo whimboo closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants