-
Notifications
You must be signed in to change notification settings - Fork 59
Add an accessibility self-review to TAG design reviews. #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to do this at all. Instead, I think we should minimise dependencies between the horizontal reviews, and leave the accessibility review with the group that already owns it. I've noticed this before with privacy/security reviews, where there seems to be TAG review duplication.
Perhaps what TAG really wants is to make sure that the other HR reviews have been initiated before TAG begins on their review? That way TAG can go and look up the inputs to those other reviews.
My perspective here is that of a Chair of a WG that needs to request reviews from time to time, and wanting that process to be as efficient as possible - in my view this change reduces efficiency.
I don't think that the intent is to have the TAG review blocked on accessibility, but only to make it easy to find the different reviews. Still, I find @nigelmegitt's argument persuasive. The template is already unwieldy enough. |
We're currently using the same intake forms for browser-driven reviews as WG-driven reviews, and maybe it makes sense to split them. For WGs, we should ask for a link to the issue that lists all the horizontal reviews, and omit any questions that the other groups would cover. For Chromium, until their process requires more wide review than just the TAG, we need to include the references to other topics to ensure they don't just get forgotten. If other browsers start requesting review before they ship pre-CR things, we should consider what intake form they need. |
That makes sense @jyasskin. The only TAG-specific HR deliverable for a WG should be the explainer, which actually should be useful for all the HR groups. Tempting to start trying to adjust the HR process here, but it's not the right forum. |
Quick update on work being done in TAG and APA here...
I also agree with both @nigelmegitt and @martinthomson that the process needs to be simple for requesters of reviews, and that hopefully these things in concert will achieve that. My proposal would be that when we have the 'friendly' versions of the two questionnaires at MVP level we could point to them, from TAG's perspective, via this PR. I'm away for a week after today but I expect our proposed forms to be ready within a week or so. |
P.S. Perhaps it might help to post this here too... I looked at the current HR process. Actually accessibility is the only area that has two totally separate questionnaires - though I agree that the TAG one is a good starting point for early reviews, and a good 'relay' for whether deeper review is needed.
Updates:
|
@matatk Is https://w3c.github.io/fast/checklist.html the right questionnaire to ask people to fill out? I think I'd like to wait to merge this until there's a markdown template for people to copy, like with https://github.com/w3c/security-questionnaire/blob/main/questionnaire.markdown. Then I also want to get some folks who propose HTML and CSS features to review that checklist to ensure that it's not too much of a burden to fill it out.