Skip to content

Menu-like behavior #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Menu-like behavior #16

merged 7 commits into from
Feb 11, 2025

Conversation

RobertOrthofer
Copy link
Contributor

@RobertOrthofer RobertOrthofer commented Feb 11, 2025

This PR implements changes according to #15

  • The default size has been set via the prop of the v-autocomplete, the wrapping element has been removed, as well as the now-obsolete css import of the example application. Now it should integrate like a normal v-autocomplete, although some styling props like density, single-line or min-width are set by the plugin itself.
  • The menu-like behavior is now implemented with a proper v-menu, that has the v-autocomplete as the target, but no activator, so we still have full control. Vuetify detaches menus from the DOM, and uses <teleport> to "attach" them back to the location of their target, which makes them appear over any other element, even when used in a navigation bar with overflow: hidden, like in the example application.
  • some good-practives have been implemented for the v-list-item, but there is still a well-known bug in vuetify that throws warnings for nodes with duplicate IDs inside a v-virtual-scoll element.

Copy link
Contributor

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I only added a minor suggestion you might want to address.

@ahocevar ahocevar merged commit 15c45a3 into main Feb 11, 2025
1 check passed
@ahocevar ahocevar deleted the default-size branch February 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants