Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp: Add bits_format=byte_array support #992

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

wader
Copy link
Owner

@wader wader commented Aug 19, 2024

Represent binary values into an array of bytes when turn values into JSON

@wader
Copy link
Owner Author

wader commented Aug 19, 2024

@mrcook

@wader
Copy link
Owner Author

wader commented Aug 19, 2024

Still not sure if it should be byte_array or bytes_array 🤔

Represent binary values into an array of bytes when turn values into JSON
@wader wader changed the title interp: Add bits_format=bytes_array support interp: Add bits_format=byte_array support Aug 20, 2024
@wader
Copy link
Owner Author

wader commented Aug 20, 2024

"byte array" seems to be more common when i search around a bit, going with that

@wader wader merged commit 5766566 into master Aug 20, 2024
5 checks passed
@wader wader deleted the bits-format-bytes-array branch August 20, 2024 07:22
@wader
Copy link
Owner Author

wader commented Aug 20, 2024

@mrcook feel free to add some tzx docs using byte_array now if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant