✨ 더 공평한 리뷰어 선정 #398
Open
✨ 더 공평한 리뷰어 선정 #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yeolyi님 2025. 5. 6.까지 리뷰 부탁드립니다 🎉 |
yeolyi
reviewed
May 8, 2025
| @@ -11,17 +11,49 @@ jobs: | |||
| random-reviwer: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - id: random_reviwer | |||
Comment on lines
+37
to
+48
| for (const pr of recentPRs.data) { | ||
| const reviewers = await github.rest.pulls.listRequestedReviewers({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: pr.number | ||
| }); | ||
| for (const reviewer of reviewers.data.users) { | ||
| if (reviewCounts[reviewer.login] !== undefined) { | ||
| reviewCounts[reviewer.login]++; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
루프 안에 await이 있는데 Promise.all을 활용해보는건 어떤가요?
Comment on lines
+32
to
+35
| const reviewCounts = {}; | ||
| candidateList.forEach(reviewer => { | ||
| reviewCounts[reviewer] = 0; | ||
| }); |
There was a problem hiding this comment.
아래에서는 for of를 사용하고 여기서는 forEach를 사용했는데 의도가 있을까요? 없다면 통일해도 좋을 것 같습니다 :)
There was a problem hiding this comment.
아래쪽에서 map이랑 filter를 쓰는걸 보면 함수형 프로그래밍 느낌이 좀 나는데 여기도 reduce로 바꿔볼 수는 있겠네요. 상관은 없습니다 ㅎㅎ
Comment on lines
+23
to
+30
| const recentPRs = await github.rest.pulls.list({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| state: 'all', | ||
| sort: 'updated', | ||
| direction: 'desc', | ||
| per_page: 10 | ||
| }); |
There was a problem hiding this comment.
사소한데 도움이 될까해서 남기자면...
이건 개발자별로 취향일 수 있지만 저는 변수 정의 위치랑 사용 위치가 가까운걸 좋아하는데요,
recentPRs는 저 아래 for of에서 처음 사용되니 변수 위치를 좀 내려도 좋을 것 같습니다.
yeolyi
reviewed
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #366
작업 내용
최근 PR 목록을 가져온 뒤, 각각의 목록의 Reviewer들을 counts해 가장 적은 수의 사람을 선택합니다.
2명 이상일 경우 random으로 지정해요!