Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 and Django 5.0 #69

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Dec 12, 2023

  • Add Python 3.12 and Django 5.0 to the testing matrix.
  • Bump maximum versions of numpy and scipy to versions that can be installed in Python 3.12.

@mgax mgax marked this pull request as ready for review December 12, 2023 11:30
Copy link
Contributor

@tomusher tomusher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't think anyone would argue with dropping support for Django <4.2 going forward if that's something you need to do for e.g. feature support/maintenance simplicity.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31909a4) 87.84% compared to head (883038b) 87.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          15       15           
  Lines         732      732           
  Branches      137      137           
=======================================
  Hits          643      643           
  Misses         54       54           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -36,6 +36,7 @@
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Framework :: Django",
"Framework :: Django :: 3.2",
"Framework :: Django :: 4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgax could you please add the Django 5.0 trove classifier too?

setup.py Outdated
Comment on lines 52 to 53
"numpy>=1.19.4,<1.27",
"scipy>=1.5.4,<1.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can open this up and make this <2

(Would be even more awesome if we could move the entire 'winner' calculation which requires these dependencies to the database and drop the need to install these heavyweight dependencies. Maybe some future day...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can open this up and make this <2

Since we're using a tiny bit of the numpy/scipy APIs, this does seem like a low-risk change. I've loosened the constraints.

@mgax mgax requested a review from Stormheg December 13, 2023 12:49
Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@Stormheg Stormheg merged commit 62b2ba2 into wagtail-nest:main Dec 13, 2023
11 checks passed
@mgax mgax deleted the py312 branch December 14, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants