Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance, support for Wagtail 6.2, format with ruff, switch to pyproject.toml #87

Merged
merged 23 commits into from
Sep 17, 2024

Conversation

Stormheg
Copy link
Member

No description provided.

@Stormheg Stormheg force-pushed the maintenance branch 3 times, most recently from 26728b2 to dd494a4 Compare September 14, 2024 21:12
@Stormheg Stormheg force-pushed the maintenance branch 4 times, most recently from 3c4de1a to 3333998 Compare September 14, 2024 21:26
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 92.35880% with 23 lines in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (b22a554) to head (792167b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...igrations/0011_rename_treatment_to_variant_data.py 11.11% 8 Missing ⚠️
...ons/0007_grant_moderators_add_abtest_permission.py 0.00% 6 Missing ⚠️
wagtail_ab_testing/models.py 94.44% 2 Missing and 1 partial ⚠️
wagtail_ab_testing/wagtail_hooks.py 91.17% 1 Missing and 2 partials ⚠️
wagtail_ab_testing/compat.py 33.33% 1 Missing and 1 partial ⚠️
wagtail_ab_testing/utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   88.44%   93.45%   +5.01%     
==========================================
  Files          15       42      +27     
  Lines         753     1620     +867     
  Branches      140      163      +23     
==========================================
+ Hits          666     1514     +848     
- Misses         51       69      +18     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stormheg
Copy link
Member Author

@mgax would you mind reviewing this? I know it's a lot, but your help goes a long way 🫶

This fixes the report view in Wagtail 6.2 – I'm sure a particular client of yours is interested in that 😄

Copy link
Contributor

@mgax mgax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much props for doing all this work! I've left a few small comments.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
wagtail_ab_testing/views.py Show resolved Hide resolved
wagtail_ab_testing/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mgax mgax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 👏

@Stormheg Stormheg merged commit c305364 into wagtail-nest:main Sep 17, 2024
9 checks passed
@Stormheg Stormheg deleted the maintenance branch September 17, 2024 16:58
@Stormheg
Copy link
Member Author

Thanks so much Alex! This has now been released: https://pypi.org/project/wagtail-ab-testing/0.11/

@mgax
Copy link
Contributor

mgax commented Sep 17, 2024

@Stormheg thanks for doing all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants