-
Notifications
You must be signed in to change notification settings - Fork 22
Add linting to CI and pre commit #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting to CI and pre commit #96
Conversation
|
I also ran pre-commit once locally to lint all templates, css, json, yaml and pushed the changes. This should ensure consistency across the codebase. |
| with: | ||
| python-version: 3.13 | ||
| - uses: pre-commit/[email protected] | ||
| lint_precommit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the name from lint_python to lint_precommit.
| python-version: 3.13 | ||
| - uses: pre-commit/[email protected] | ||
| with: | ||
| extra_args: --all-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument is the only change in the workflow except the renaming.
.pre-commit-config.yaml
Outdated
| rev: v3.1.0 | ||
| hooks: | ||
| - id: prettier | ||
| types_or: [css, scss, json, yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't add JS linting as it is already included in the workflow.
Just mentioning the changed files, because there are so many changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 43 43
Lines 1690 1690
Branches 111 111
=======================================
Hits 1585 1585
Misses 69 69
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b39cdb to
e3a8a71
Compare
e3a8a71 to
1e0feb5
Compare
Stormheg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joelwilliam2005, I've rebased your PR and updated the hooks to their latest version and pinned prettier in package.json
Fixes issue #95