Skip to content

Conversation

@joelwilliam2005
Copy link
Contributor

Fixes issue #95

@joelwilliam2005
Copy link
Contributor Author

I also ran pre-commit once locally to lint all templates, css, json, yaml and pushed the changes. This should ensure consistency across the codebase.

with:
python-version: 3.13
- uses: pre-commit/[email protected]
lint_precommit:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the name from lint_python to lint_precommit.

python-version: 3.13
- uses: pre-commit/[email protected]
with:
extra_args: --all-files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument is the only change in the workflow except the renaming.

rev: v3.1.0
hooks:
- id: prettier
types_or: [css, scss, json, yaml]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't add JS linting as it is already included in the workflow.
Just mentioning the changed files, because there are so many changes.

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (8e3f825) to head (1e0feb5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          43       43           
  Lines        1690     1690           
  Branches      111      111           
=======================================
  Hits         1585     1585           
  Misses         69       69           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Stormheg Stormheg force-pushed the fix/add-linting-to-CI-and-pre-commit branch from 3b39cdb to e3a8a71 Compare April 25, 2025 13:14
@Stormheg Stormheg force-pushed the fix/add-linting-to-CI-and-pre-commit branch from e3a8a71 to 1e0feb5 Compare April 25, 2025 13:16
Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joelwilliam2005, I've rebased your PR and updated the hooks to their latest version and pinned prettier in package.json

@Stormheg Stormheg merged commit 5bbc8b4 into wagtail-nest:main Apr 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants