Skip to content

Add option to ignore objects that fail to build #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add option to ignore objects that fail to build #69

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1765b6e
Add option to ignore objects that fail to build
May 20, 2022
47289c1
Document new config option
hughrawlinson Jun 16, 2022
c63597a
Address PR comments
hughrawlinson Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/wagtailbakery/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,14 @@ def build_object(self, obj):
self.request = RequestFactory(
SERVER_NAME=site.hostname).get(self.get_url(obj))
self.set_kwargs(obj)
path = self.get_build_path(obj)
self.build_file(path, self.get_content(obj))
try:
path = self.get_build_path(obj)
self.build_file(path, self.get_content(obj))
except Exception as exc:
if settings.BAKERY_IGNORE_OBJECTS_THAT_FAILED_TO_BUILD:
logger.error("Failed to build object %s: %s" % (obj, exc))
else:
raise exc

def build_queryset(self):
for item in self.get_queryset().all():
Expand Down