Add basic personalisation blocks #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm-kn
changed the title
tomdyson
reviewed
May 31, 2017
|
|
||
|
|
||
| def list_segment_choices(): | ||
| """Get a list of segment choices visible in the admin site when editting |
tm-kn
force-pushed
the
feature/#68-improve-personalised-fields
branch
from
ee93ad4 to
d4dcd4c
Compare
tm-kn
force-pushed
the
feature/#68-improve-personalised-fields
branch
from
d4dcd4c to
90c8c05
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 68.47% 68.47%
=======================================
Files 55 55
Lines 2217 2217
=======================================
Hits 1518 1518
Misses 699 699
Continue to review full report at Codecov.
|
tm-kn
force-pushed
the
feature/#68-improve-personalised-fields
branch
2 times, most recently
from
f5af8e8 to
a71a703
Compare
Collaborator
|
@tm-kn can you look at the 2.7 failures, please? |
tm-kn
force-pushed
the
feature/#68-improve-personalised-fields
branch
5 times, most recently
from
d7d63ad to
912b46c
Compare
tm-kn
changed the title
jberghoef
force-pushed
the
feature/#68-improve-personalised-fields
branch
from
912b46c to
1d18a82
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 66 66
Lines 2010 2010
=======================================
Hits 1866 1866
Misses 144 144Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #68
Add "visible to everyone" segment setting for
PersonalisedStructBlock.Add the
render_fieldskeyword argument forPersonalisedStructBlock. Setting of the same name can be also set onMetaclass of the block.StructBlock'srender()(as currently, displaying field titles & content or template specified inMeta).Add a few more default blocks so they work out of the box.
PersonalisedCharBlockPersonalisedImageChooserBlockPersonalisedRichTextBlockPersonalisedTextBlock