allow edit headings' anchor ids #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jacobtoppm any chance this PR can be reviewed? |
emilytoppm
reviewed
Mar 24, 2023
| onRemove(e) { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| this.setState({ showTooltipAt: null }); |
Collaborator
There was a problem hiding this comment.
This doesn't actually remove it, which feels confusing.
Author
There was a problem hiding this comment.
Thx, I will check and let you know soon
Author
There was a problem hiding this comment.
I have fixed. Now onRemove sets anchor to null, which means that slugified header text will be set as id. Also I have renamed button to 'Reset'.
Author
There was a problem hiding this comment.
@jacobtoppm will you have time to have a look?
Author
|
any chance this PR can be approved/reviewed? |
Author
|
@jacobtoppm any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to solve issue.
PR includes: