Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more demo data & features #436

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

thibaudcolas
Copy link
Member

Solves part of #175, particularly things we’d want to have for demos & audits or common features. This might be easier to review com

  • Promoted search results. Includes a basic implementation of the feature, and demo data.
  • Demo users, to simplify switching between languages and groups, as well as checking what an inactive user looks like
  • Demo redirects, based on real examples from the project (as part of renaming pages where the slug was incorrect, and demonstrating common typos)
  • Wagtail’s dynamic image serve view. Bit of a niche feature but useful to be able to demo it when needed
  • Focal points

Compared to #175, still missing are pages in different states, revisions, and documents

Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this!

I've added a section to the readme documenting the different users. Does this look okay to you @thibaudcolas?

Feel free to merge.

@thibaudcolas thibaudcolas merged commit ce1d757 into wagtail:main Aug 11, 2023
3 checks passed
@thibaudcolas thibaudcolas deleted the feature/demo-data branch August 11, 2023 12:31
@thibaudcolas
Copy link
Member Author

Thank you @Stormheg @laymonage! I switched the users’ documentation to a table so it’s simpler to compare the available options at a glance. Our new users are:

  • Eddy Thorsørensen
  • Jordan Rules
  • Iman Absent
  • Friedrich Wilhelm von Braunenberg
  • Nour al-Hudā

I tried to add examples that were somewhat representative for German from Germany and Arabic from Lebanon speakers, with a mixture of lengths, and diacritics / non-latin characters.

@laymonage
Copy link
Member

OMG, Eddy Thor(sørensen) is now canon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants