Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace search models and remove fields for wagtail 6 #459

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

fadedsky
Copy link
Contributor

@fadedsky fadedsky commented Nov 3, 2023

Was unable to complete the setup for docker-wagtail-develop, made changes to the fixture to complete the setup.

Reported the issue here: wagtail/docker-wagtail-develop#67

  • Replaced wagtailsearch.query with wagtailsearchpromotions.query model
  • Replace wagtailsearch.querydailyhits with wagtailsearchpromotions.querydailyhits model
  • Remove permission_type from wagtailcore.grouppagepermission model
  • Remove submitted_for_moderation from wagtailcore.revision model

Was able to run bakerydemo in docker-wagtail-develop after.

@zerolab
Copy link
Collaborator

zerolab commented Nov 3, 2023

I'm pretty sure this was deliberately updated in #438 to reflect changes in Wagtail 5.1

@gasman gasman self-requested a review November 3, 2023 11:20
@laymonage
Copy link
Member

laymonage commented Nov 3, 2023

I'm pretty sure this was deliberately updated in #438 to reflect changes in Wagtail 5.1

I think it's different, this one handles the removal of the deprecated submitted_for_moderation from the old moderation system, as well as removals of other deprecated features in 6.0.

@gasman
Copy link
Contributor

gasman commented Nov 3, 2023

@zerolab No, I think this is new - this would have been caused by the removal of deprecated database fields/tables as part of starting work on Wagtail 6 (#11148, #11154).

Looks like there's still a stray reference to wagtailsearch.querydailyhits on line 1270 of bakerydemo.json.

@gasman
Copy link
Contributor

gasman commented Nov 3, 2023

Thanks for catching this @fadedsky! Have updated the remaining reference to wagtailsearch.querydailyhits and confirmed that the database can be brought up successfully against both the main (6.0) branch and the stable/5.2.x release branch.

@gasman gasman merged commit a91324b into wagtail:main Nov 3, 2023
3 checks passed
@zerolab
Copy link
Collaborator

zerolab commented Nov 3, 2023

argh, my bad. Sorry for the noise. And thank you for catching this @fadedsky 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants